Skip to content

Marshall JsonApiException thrown from JsonConverter #1690

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Feb 23, 2025

Marshall JsonApiException thrown from JsonConverter such that the source pointer can be reconstructed.

This is currently only exposed for OpenAPI usage, because it relies on undocumented internals of System.Text.Json that may break in the future. When it does, there may not be a way anymore to provide this, so users shouldn't take a dependency on it.

QUALITY CHECKLIST

@bkoelman bkoelman force-pushed the marshall-source-pointer branch 2 times, most recently from ca306bd to acfae9f Compare February 23, 2025 22:40
@bkoelman bkoelman force-pushed the marshall-source-pointer branch from acfae9f to fa253cc Compare February 23, 2025 22:42
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.64%. Comparing base (caba090) to head (fa253cc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ization/Request/NotSupportedExceptionExtensions.cs 73.91% 2 Missing and 4 partials ⚠️
...iDotNetCore/Serialization/Request/JsonApiReader.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1690      +/-   ##
==========================================
- Coverage   90.69%   90.64%   -0.05%     
==========================================
  Files         354      355       +1     
  Lines       11537    11567      +30     
  Branches     1901     1908       +7     
==========================================
+ Hits        10463    10485      +22     
- Misses        702      706       +4     
- Partials      372      376       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review February 23, 2025 22:54
@bkoelman bkoelman merged commit 7eec5ca into master Feb 23, 2025
16 checks passed
@bkoelman bkoelman deleted the marshall-source-pointer branch February 23, 2025 23:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant