Skip to content

Merge master into openapi #1694

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 11 commits into from
Mar 2, 2025
Merged

Merge master into openapi #1694

merged 11 commits into from
Mar 2, 2025

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Mar 2, 2025

Merges the master branch into openapi, which updates FluentAssertions and removes custom Should methods.

bkoelman added 8 commits March 1, 2025 09:33
* Replace DOTNET_SKIP_FIRST_TIME_EXPERIENCE with DOTNET_NOLOGO

* Fix broken build on .NET SDK v9.0.200
* Update Resharper

* Update FluentAssertions package

* Remove ShouldHaveCount

* Remove ShouldNotBeEmpty

* Remove ShouldNotBeNullOrEmpty

* Remove ShouldOnlyContainKeys

* Remove ShouldContainKey

* Remove ShouldNotBeNull and redundant With calls
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 84.52055% with 226 lines in your changes missing coverage. Please review.

Project coverage is 90.35%. Comparing base (7eec5ca) to head (61c6cd5).
Report is 333 commits behind head on openapi.

Files with missing lines Patch % Lines
...uckle/JsonApiActionDescriptorCollectionProvider.cs 88.09% 3 Missing and 7 partials ⚠️
...etCore.OpenApi.Swashbuckle/ParameterInfoWrapper.cs 61.53% 10 Missing ⚠️
...tors/Bodies/AtomicOperationsBodySchemaGenerator.cs 91.15% 5 Missing and 5 partials ⚠️
...e.OpenApi.Swashbuckle/OpenApiEndpointConvention.cs 94.15% 4 Missing and 5 partials ⚠️
...pi.Client.NSwag/BlockedJsonInheritanceConverter.cs 41.66% 7 Missing ⚠️
...piDotNetCore.OpenApi.Client.NSwag/JsonApiClient.cs 95.39% 2 Missing and 5 partials ⚠️
...Links/ResourceIdentifierCollectionTopLevelLinks.cs 0.00% 7 Missing ⚠️
...piObjects/Links/ResourceCollectionTopLevelLinks.cs 0.00% 6 Missing ⚠️
....OpenApi.Swashbuckle/OpenApiOperationIdSelector.cs 88.23% 3 Missing and 3 partials ⚠️
...erators/Components/DataContainerSchemaGenerator.cs 86.95% 3 Missing and 3 partials ⚠️
... and 51 more
Additional details and impacted files
@@             Coverage Diff             @@
##           openapi    #1694      +/-   ##
===========================================
- Coverage    90.64%   90.35%   -0.29%     
===========================================
  Files          355      462     +107     
  Lines        11567    14076    +2509     
  Branches      1908     2198     +290     
===========================================
+ Hits         10485    12719    +2234     
- Misses         706      918     +212     
- Partials       376      439      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review March 2, 2025 13:17
@bkoelman bkoelman merged commit 749e588 into openapi Mar 2, 2025
16 checks passed
@bkoelman bkoelman deleted the merge-master-into-openapi branch March 2, 2025 14:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant