PHP 8.4 deprecation warnings #719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
To avoid PHP 8.4 deprecation warnings, introduce explicitly nullable types where null is used as a default value.
Background
PHP 8.4 will introduce a new deprecation warning, where
nullis used as a default value, but the typehint is not explicitly nullable. See the PHP 8.4 approved RFC.This is causing deprecation warnings in downstream projects - see this failing build in Composer.
Solution
Use nullable types in method signatures, wherever
nullis used as a default value.Note on PHP versions
The nullable type feature was introduced in PHP 7.1. This pull request proposes a new version of
justinrainbow/json-schemawhich explicitly requires PHP 7.1+. Users of PHP 5.3 - 7.0 would not get this version of the project.