Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Extend pipeline for newer versions php #746

Merged
merged 20 commits into from
Aug 27, 2024

Conversation

DannyvdSluijs
Copy link
Collaborator

@DannyvdSluijs DannyvdSluijs commented Aug 5, 2024

This PR updates the pipeline to include PHP >= 8.0 and no longer include PHP <= 7.1. In addition the PR contains the following changes to have green results.

  • Update to PHPUnit 8.5 to resolve invocations of deprecated/removed method each(), see https://www.php.net/manual/en/function.each.php. Which resulted in:
    • Add void return types to ::setup() methods
    • Explicitly include phpspec/prophecy
    • Replace ::setExpectedException() and @ExpectedException for ::expectException
    • Replace ::assertInternalType() with assertIs*() methods
    • Replace ::getMock() with ::createMock()
  • Improve test assertions in case of warning or error during test run.
  • Port Fix ObjectIterator for PHP8 #682 to fix deprecations from ObjectIterator
  • Port [PHP 8.4] Fixes for implicit nullability deprecation #717 to fix implicit nullable deprecations
  • Update icecave/parity to ^3,0 to resolve invocations of deprecated/removed method each()
  • Correct styles reported by GHA workflow

Copy link
Contributor

@Seldaek Seldaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good !

@DannyvdSluijs DannyvdSluijs merged commit 2eb0def into master Aug 27, 2024
18 checks passed
@DannyvdSluijs DannyvdSluijs deleted the Extend-pipeline-for-newer-versions-php branch August 27, 2024 07:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants