Skip to content

Parse ALTER TABLE ADD/DROP COLUMN statement and sync table_map #511

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dongwook-chan
Copy link
Collaborator

I've noticed that a recent change in the repository removed the ability to select from information_schema to retrieve column_schema. Instead, it was chosen to parse the optional metadata present in the table map event to obtain this schema. I understand the rationale behind this, but there's a caveat: if binlog_row_metadata is set to FULL, the optional metadata isn't always fully available. This can lead to incomplete or incorrect column schemas.

To address this gap, I've developed a feature that parses the DDL from the query event and updates the table_map accordingly. This ensures that even when binlog_row_metadata is set to FULL, we can accurately and consistently retrieve the column schema.

Changes Made:

Implemented DDL parsing from query events.
Updated table_map to reflect changes from parsed DDL.
Added necessary unit tests to ensure correctness and stability of the new feature.
Benefits:

Ensures that column schemas are always accurate, even when binlog_row_metadata is set to FULL.
Reduces reliance on optional metadata which might be incomplete.
I'd appreciate it if you could review the changes and provide feedback. I believe this enhancement can add robustness to the way column schemas are determined, ensuring accuracy and consistency for all configurations.

@dongwook-chan dongwook-chan requested a review from sean-k1 October 6, 2023 18:51
@sean-k1
Copy link
Collaborator

sean-k1 commented Oct 20, 2023

@dongwook-chan Could you change this pr to draft?

@dongwook-chan
Copy link
Collaborator Author

Sure! 😁😁

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants