Skip to content

Fix SyntaxWarning from update message #7453

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: 6.5.x
Choose a base branch
from

Conversation

living180
Copy link

The use of backslashes in the ASCII-art "Update" banner results in an "invalid escape sequence" SyntaxWarning under Python 3.12. Fix by changing the banner string to a raw string (which ignores backslashes).

The use of backslashes in the ASCII-art "Update" banner results in an "invalid escape sequence" SyntaxWarning under Python 3.12.  Fix by changing the banner string to a raw string (which ignores backslashes).
@JasonWeill JasonWeill added the bug label Sep 10, 2024
@JasonWeill
Copy link
Collaborator

@living180 Thank you for opening this pull request! Notebook 6 code is now maintained as part of nbclassic, or Classic Notebook. Looks like this style of string is being used in nbclassic as well:

https://github.com/jupyter/nbclassic/blob/abe28bc4fe5d3e026c68c01248047656f58db635/nbclassic/notebookapp.py#L328-L333

Can you please open an issue in nbclassic and open a pull request in that repo instead? Thanks again for your contribution.

@living180
Copy link
Author

Done - jupyter/nbclassic#297. Thanks for the input!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants