Add dynamic versions #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NDagestad
force-pushed
the
version_cmd
branch
2 times, most recently
from
492e22d to
ff6abf7
Compare
Merged
k0retux
approved these changes
Mar 20, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a
--versionargument to the cli and make the internal fuddly_version variable be automatically generated by the build system.The version produced by the build system composed of the latest tag available on the branch + the distance from it.
The version is added to fuddly/framework/_version.py (can be another file if you prefer).
If the file is not found, a default value hardcoded in fuddly is used after issuing a warning to the user.
Due to how the master branch has been tagged up until now, a new version with a new tag will be needed and the develop branch must be rebased on master after the merge to contain the actually tagged commit (which is usually the merge commit)