Skip to content

feat: allow tagging in incident comments #4669

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rohitdash08
Copy link

@rohitdash08 rohitdash08 commented May 1, 2025

/claim #2187
Fixes #2187

Closes #

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Copy link

vercel bot commented May 1, 2025

@rohitdash08 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label May 1, 2025
@CLAassistant
Copy link

CLAassistant commented May 1, 2025

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added API API related issues Incident labels May 1, 2025
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before reviewing this PR - can you add e2e test for this? so I'll be able to reproduce?

@rohitdash08
Copy link
Author

@shahargl, I have added the e2e test
Please let me know if anything else is required from my end.

@rohitdash08 rohitdash08 changed the title allow tagging in incident comments Enhancement: allow tagging in incident comments May 3, 2025
@rohitdash08 rohitdash08 changed the title Enhancement: allow tagging in incident comments feat: allow tagging in incident comments May 3, 2025
@skynetigor
Copy link
Contributor

Hey!
Quick question β€” since we’re already using ReactQuill, could we integrate quill-mention to handle mentions instead of building a custom input from scratch?
It seems like a lighter approach, given that Quill is already part of our stack.

@rohitdash08
Copy link
Author

Hey @skynetigor, I have made the required changes right now we are using react quill as you suggested.
Please let me know if anything else is required from my end.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
API API related issues πŸ™‹ Bounty claim Incident size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[πŸ”¨ Enhancement]: Allow tagging in Incident comment
4 participants