Skip to content

Add Histogram indicator plot style kernc#195 #381

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 33 commits into from
Closed

Add Histogram indicator plot style kernc#195 #381

wants to merge 33 commits into from

Conversation

zlpatel
Copy link
Contributor

@zlpatel zlpatel commented Jun 15, 2021 •
edited by kernc
Loading

Continued in #384.

zlpatel and others added 30 commits May 22, 2021 19:30
@zlpatel
Auto-scale Y-axis for indicators when zooming kernc#356
0581c55
@zlpatel
Auto-scale Y-axis for indicators when zooming kernc#356
7792588
@zlpatel
Auto-scale Y-axis for indicators when zooming kernc#356
4ff1fe8
@zlpatel
Auto-scale Y-axis for indicators when zooming kernc#356
c0dcbbe
@zlpatel
Auto-scale Y-axis for indicators when zooming kernc#356
6b1c436
@zlpatel
Auto-scale Y-axis for indicators when zooming kernc#356
bf03b63
@zlpatel
Merge pull request #1 from zlpatel/kernc#356
2cc6724 
Merging kernc#356
@zlpatel
Trailing pct instead of ATR kernc#223
46cffe3
@zlpatel
Trailing pct instead of ATR kernc#223
8eab87c 
Add code description and use float type for default percentage value.
@zlpatel
Test case for PercentageTrailingStrategy kernc#223
d6fa851
@zlpatel
Merge pull request #2 from zlpatel/kernc#223
d81ae85 
Trailing pct instead of ATR kernc#223
@zlpatel
Added blank line to fix lint issue kernc#223
b045c7c
@zlpatel
added blank space to fix lint issue kernc#223
3ef557a
@zlpatel
added blank line to fix lint issue kernc#223
898969c
@zlpatel
Added blank line to fix lin issue kernc#223
a7732f2
@zlpatel
Merge pull request #3 from zlpatel/kernc#223
18ecead 
Trailing pct instead of ATR kernc#223
@zlpatel
Auto-scale Y-axis for Profit/Loss chart when zooming kernc#356
5ca9a59
@zlpatel
Auto-scale Y-axis for PL chart when zooming kernc#356
ab17cbf
@zlpatel
Add auto scaling of y-axis for PL chart kernc#356
44a0200
@zlpatel
Add whitespace after , to fix lint issue kernc#356
307e4ff
@zlpatel
Fixing build error by adding [:] kernc#356
97712c7
@zlpatel
Remove y-axis scaling logic for PnL graph kernc#356
1494396
@zlpatel
Remove y-axis scaling logic for PnL graph kernc#356
95e03f8
@zlpatel
Reverted: Auto-scale Y-axis for Profit/Loss chart when zooming kernc#356
44b2519 


Reverted: Auto-scale Y-axis for Profit/Loss chart when zooming kernc#356
@zlpatel
Add Histogram indicator plot style kernc#195
bf2585c
@zlpatel
Fix legends values on histogram kernc#195
dea0663
@zlpatel
Fix lint issues kernc#195
45be275
@zlpatel
Fix lint issues kernc#195
8eb9a68
@zlpatel
Fix lint issues kernc#195
b4bc123
@zlpatel
Fix lint issues kernc#195
67e2fff
@Benouare
Copy link
Contributor

Hi,
I think that you may merge all your commits via rebase -i to get only one commit for all your modifications.
see u

Benouare
Benouare suggested changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@Benouare Benouare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase -i to get a cleaner history?

@zlpatel zlpatel closed this Jun 16, 2021
@zlpatel zlpatel deleted the kernc#195 branch June 16, 2021 04:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Benouare Benouare Benouare requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zlpatel @Benouare