Change input element renaming style #7
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was using this repo as a component for another project of mine, and I found that the logic in the
core.js
file (especially thegetNodeByRjsfId
) could be simplified if we just change the renaming style of similar Menu elements.Since the node's rjsf-id uses
_
as a separator between properties (templatename_parentname_...), I think using a different separator would be better.P.S.: Really great work on building this form builder. Great code. 🙏