Address oneAPI 2025 deprecations #278
Conversation
There was a problem hiding this comment.
The changes are ok to me. I think there are remaining deprecation warnings like
/work/fft/src/KokkosFFT_SYCL_plans.hpp:126:51: warning: 'CONJUGATE_EVEN_STORAGE' is deprecated [-Wdeprecated-declarations]
126 | plan->set_value(oneapi::mkl::dft::config_param::CONJUGATE_EVEN_STORAGE,
/work/fft/src/KokkosFFT_SYCL_plans.hpp:112:9: warning: 'set_value' is deprecated: Use set_value(config_param, const std::vector<std::int64_t>&) instead. [-Wdeprecated-declarations]
112 | plan->set_value(oneapi::mkl::dft::config_param::INPUT_STRIDES,
fft/src/KokkosFFT_SYCL_plans.hpp
Outdated
| in_strides.data()); | ||
| plan->set_value(oneapi::mkl::dft::config_param::OUTPUT_STRIDES, | ||
| plan->set_value(oneapi::mkl::dft::config_param::BWD_STRIDES, |
There was a problem hiding this comment.
It looks like the macros FWD_STRIDES and BWD_STRIDES are available in older versions of Intel MKL also. Have INPUT_STRIDES and OUTPUT_STRIDES alone been deprecated?
There was a problem hiding this comment.
According to the errors, INPUT_STRIDES and OUTPUT_STRIDES have been deprecated.
There was a problem hiding this comment.
FWD_STRIDES and INPUT_STRIDES are having the same meaning. Same with BWD_STRIDES and OUTPUT_STRIDES. I was curious about that.
Good catch. It may be that we can remove |
|
Are you fine with the current change? Or you think it is better to suppress Since I cannot test this on Intel GPU now, I would like to keep it until I confirm that it is OK to be removed |
|
Should we wait until we can test all the changes to merge then ? |
|
Has Kokkos fixed all these warnings about |
Yes, with this In the nightly, you may find almost no warnings from kokkos codes |
This PR addresses the oneAPI 2025 deprecations as found in Nightly builds.