-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
12 nonsense values in pv generation today metric (#20)
- Loading branch information
Showing
15 changed files
with
238 additions
and
69 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package filters | ||
|
|
||
| import ( | ||
| "errors" | ||
|
|
||
| "github.com/kubaceg/sofar_g3_lsw3_logger_reader/ports" | ||
| ) | ||
|
|
||
| var ErrDailyGenerationDiffTooHigh = errors.New("daily generation spike detected, skipping") | ||
|
|
||
| type DailyGenerationSpikesFilter struct { | ||
| lastDailyGenerationValue uint32 | ||
| maxDailyGenerationDiff uint32 | ||
| } | ||
|
|
||
| func NewDailyGenerationFilter(maxDailyGenerationDiff uint32) *DailyGenerationSpikesFilter { | ||
| return &DailyGenerationSpikesFilter{ | ||
| maxDailyGenerationDiff: maxDailyGenerationDiff, | ||
| } | ||
| } | ||
|
|
||
| func (d *DailyGenerationSpikesFilter) Filter(data ports.MeasurementMap) (ports.MeasurementMap, error) { | ||
| // If the last daily generation value is higher than the current one, it means a new day has started | ||
| if data["PV_Generation_Today"].(uint32) < d.lastDailyGenerationValue { | ||
| d.lastDailyGenerationValue = 0 | ||
| } | ||
|
|
||
| if d.lastDailyGenerationValue > 0 && | ||
| data["PV_Generation_Today"].(uint32)-d.lastDailyGenerationValue > d.maxDailyGenerationDiff { | ||
| return nil, ErrDailyGenerationDiffTooHigh | ||
| } | ||
|
|
||
| d.lastDailyGenerationValue = data["PV_Generation_Today"].(uint32) | ||
|
|
||
| return data, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| package filters | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/kubaceg/sofar_g3_lsw3_logger_reader/ports" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestFilterCases(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| lastDailyGenerationValue uint32 | ||
| data ports.MeasurementMap | ||
| expectedResult ports.MeasurementMap | ||
| expectedError error | ||
| }{ | ||
| { | ||
| name: "ValidData", | ||
| lastDailyGenerationValue: uint32(0), | ||
| data: ports.MeasurementMap{"PV_Generation_Today": uint32(5000)}, | ||
| expectedResult: ports.MeasurementMap{"PV_Generation_Today": uint32(5000)}, | ||
| expectedError: nil, | ||
| }, | ||
| { | ||
| name: "DiffTooHigh", | ||
| lastDailyGenerationValue: uint32(9000), | ||
| data: ports.MeasurementMap{"PV_Generation_Today": uint32(20000)}, | ||
| expectedResult: nil, | ||
| expectedError: ErrDailyGenerationDiffTooHigh, | ||
| }, | ||
| { | ||
| name: "FirstDataPoint", | ||
| lastDailyGenerationValue: uint32(0), | ||
| data: ports.MeasurementMap{"PV_Generation_Today": uint32(15000)}, | ||
| expectedResult: ports.MeasurementMap{"PV_Generation_Today": uint32(15000)}, | ||
| expectedError: nil, | ||
| }, | ||
| { | ||
| name: "ExactMaxDiff", | ||
| lastDailyGenerationValue: uint32(10000), | ||
| data: ports.MeasurementMap{"PV_Generation_Today": uint32(20000)}, | ||
| expectedResult: ports.MeasurementMap{"PV_Generation_Today": uint32(20000)}, | ||
| expectedError: nil, | ||
| }, | ||
| { | ||
| name: "NewDay", | ||
| lastDailyGenerationValue: uint32(10000), | ||
| data: ports.MeasurementMap{"PV_Generation_Today": uint32(500)}, | ||
| expectedResult: ports.MeasurementMap{"PV_Generation_Today": uint32(500)}, | ||
| expectedError: nil, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| filter := NewDailyGenerationFilter(10000) | ||
| filter.lastDailyGenerationValue = tt.lastDailyGenerationValue | ||
|
|
||
| result, err := filter.Filter(tt.data) | ||
|
|
||
| if tt.expectedError != nil { | ||
| assert.Error(t, err) | ||
| assert.Equal(t, tt.expectedError.Error(), err.Error()) | ||
| } else { | ||
| assert.NoError(t, err) | ||
| } | ||
|
|
||
| assert.Equal(t, tt.expectedResult, result) | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.