fix: ksm metrics were getting duplicated in openshift env using in-cluster prometheus #3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessegoodier
approved these changes
Feb 10, 2025
|
/cherry-pick v2.5 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
…uster prometheus (#3864)
|
/cherry-pick v2.6 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
…uster prometheus (#3864)
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
…uster prometheus (#3864)
kastl-ars
reviewed
Feb 11, 2025
| @@ -24,3 +24,6 @@ serviceMonitor: | |||
|
|
|||
| prometheusRule: | |||
| enabled: true | |||
|
|
|||
| kubecostMetrics: | |||
There was a problem hiding this comment.
I daresay this should read kubeStateMetrics, not kubecostMetrics...
There was a problem hiding this comment.
This should be kubecostMetrics
The helm config is different from the one that is present in opencost
cost-analyzer-helm-chart/cost-analyzer/values.yaml
Lines 554 to 558 in 6c4b54e
jessegoodier
added a commit
that referenced
this pull request
Feb 11, 2025
…-v2.6 Revert "fix: ksm metrics were getting duplicated in openshift env using in-cluster prometheus (cherry-pick #3864)"
jessegoodier
added a commit
that referenced
this pull request
Feb 11, 2025
…-v2.5 Revert "fix: ksm metrics were getting duplicated in openshift env using in-cluster prometheus (cherry-pick #3864)"
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Adds default option for disabling emitting ksm metrics when using in-cluster prometheus in an openshift environment.
Does this PR rely on any other PRs?
No
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Users installing kubecost in openshift environment using in-cluster prometheus will now not get degraded warning and will see correct number of CPU in openshift overview page.
Links to Issues or tickets this PR addresses or fixes
opencost/opencost-helm-chart#249
What risks are associated with merging this PR? What is required to fully test this PR?
No
How was this PR tested?
Installed kubecost in openshift environment with in-cluster prometheus. earlier was getting degraded warning after setting:
the warning was gone and nothing else was affected(We were getting correct etls and cost was showing up in UI).
Have you made an update to documentation? If so, please provide the corresponding PR.