sidecar: Get credentials from annotation for snapshots #1297
Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: black-dragon74 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
|
Welcome @black-dragon74! |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @black-dragon74. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XS
When a snapshotcontent is created as a result of a volumegroupsnapshot the status for it is updated by calling the ListSnapshots RPC. Some COs require the credentials to be present in order to serve this RPC. The current code tries to get credentials only from a volumesnapshotclass if present. This condition will never be met in case of VGS. This patch adapts to code to fetch the credentials from the annotations `AnnDeletionSecretRef*` if volumesnapshotclassname is not present. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
black-dragon74
force-pushed
the
get-creds-from-annon
branch
from
caaf6c8 to
6a54e58
Compare
|
/assign @xing-yang |
| @@ -290,6 +290,13 @@ func (ctrl *csiSnapshotSideCarController) checkandUpdateContentStatusOperation(c | |||
| } | |||
| } | |||
|
|
|||
| if snapshotterListCredentials == nil && volumeGroupSnapshotMemberWithGroupSnapshotHandle { | |||
There was a problem hiding this comment.
i think we dont need snapshotterListCredentials == nil check here. it will always be nil becase tge className will not be set on the content.
What type of PR is this?
/kind feature
What this PR does / why we need it:
When a snapshotcontent is created as a result of a volumegroupsnapshot the status for it is updated by calling the ListSnapshots RPC. Some COs require the credentials to be present in order to serve this RPC.
The current code tries to get credentials only from a volumesnapshotclass if present. This condition will never be met in case of VGS.
This patch adapts to code to fetch the credentials from the annotations
AnnDeletionSecretRef*if volumesnapshotclassname is not present.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: