Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enhance GitHub Actions workflows security and permissions #4445

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

yangchuansheng
Copy link
Collaborator

No description provided.

Signed-off-by: Carson Yang <yangchuansheng33@gmail.com>
Copy link
Contributor

gru-agent bot commented Apr 3, 2025

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 4e6d707 🚫 Skipped No files need to be tested {".github/workflows/docs-deploy-kubeconfig.yml":"no test value",".github/workflows/docs-deploy-vercel.yml":"no test value"}

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the security and permissions setup for GitHub Actions workflows used in documentation deployments. Key changes include the introduction of explicit permissions and concurrency configuration in the docs-deploy-vercel workflow, an update to the peaceiris/actions-gh-pages action (v4), and the modification of authentication credentials within the docs-deploy-kubeconfig workflow.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/docs-deploy-vercel.yml Added permissions and concurrency; upgraded the deploy action to v4 and switched token usage.
.github/workflows/docs-deploy-kubeconfig.yml Configured granular permissions and updated container login credentials for enhanced security.
Comments suppressed due to low confidence (2)

.github/workflows/docs-deploy-vercel.yml:79

  • Ensure that upgrading to peaceiris/actions-gh-pages@v4 does not require additional configuration changes to maintain proper deployment functionality.
uses: peaceiris/actions-gh-pages@v4

.github/workflows/docs-deploy-kubeconfig.yml:60

  • Verify that replacing github.repository_owner with github.actor meets the authentication requirements for logging into ghcr.io and does not inadvertently impact access control.
username: ${{ github.actor }}

@c121914yu c121914yu merged commit 7a07479 into labring:main Apr 3, 2025
2 of 3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants