feat: add show admin endpoint #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashin5
force-pushed
the
feat/add_show_admin_endpoint
branch
from
3b9a4b4 to
adaa2ea
Compare
lcpojr
reviewed
Nov 7, 2020
yashin5
force-pushed
the
feat/add_show_admin_endpoint
branch
2 times, most recently
from
26c8ea3 to
7ca729e
Compare
yashin5
force-pushed
the
feat/add_show_admin_endpoint
branch
from
7ca729e to
ed091f9
Compare
* chore: refactor factories * chore: change dialyzer folder * chore: update plt config
yashin5
force-pushed
the
feat/add_show_admin_endpoint
branch
from
4c8e984 to
a3ffcb2
Compare
yashin5
commented
Dec 8, 2020
yashin5
force-pushed
the
feat/add_show_admin_endpoint
branch
from
e3aaf45 to
0ca451e
Compare
lcpojr
reviewed
Apr 21, 2021
|
|
||
| using do | ||
| quote do | ||
| # Import conveniences for testing with connections | ||
| import Plug.Conn | ||
| import Phoenix.ConnTest | ||
| import RestAPI.ConnCase | ||
| import RestAPI.{ConnCase, Factory} |
There was a problem hiding this comment.
You could use the resource_manager factory here.
lcpojr
reviewed
Apr 21, 2021
Comment on lines
+1
to
+32
| defmodule RestAPI.Factory do | ||
| @moduledoc false | ||
|
|
||
| alias ResourceManager.Identities.Schemas.User | ||
| alias ResourceManager.Repo | ||
|
|
||
| @doc "Builds a default struct from the requested model" | ||
| @spec build(model :: atom()) :: struct() | ||
| def build(:user) do | ||
| %User{ | ||
| username: "my-test-username#{System.unique_integer()}", | ||
| status: "active", | ||
| is_admin: false | ||
| } | ||
| end | ||
|
|
||
| @doc "Returns the a model struct with the given attributes" | ||
| @spec build(factory_name :: atom(), attributes :: Keyword.t()) :: struct() | ||
| def build(factory_name, attributes) when is_atom(factory_name) and is_list(attributes) do | ||
| factory_name | ||
| |> build() | ||
| |> struct!(attributes) | ||
| end | ||
|
|
||
| @doc "Inserts a model with the given attributes on database" | ||
| @spec insert!(factory_name :: atom(), attributes :: Keyword.t()) :: struct() | ||
| def insert!(factory_name, attributes \\ []) when is_atom(factory_name) do | ||
| factory_name | ||
| |> build(attributes) | ||
| |> Repo.insert!() | ||
| end | ||
| end |
There was a problem hiding this comment.
Same here.
This is not necessary.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to do an admin endpoint that returns an identity