-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
WIP: integrated moodleoverflow into the global search #62
base: master
Are you sure you want to change the base?
Conversation
0c9e34d
to
c92d53c
Compare
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
============================================
+ Coverage 18.08% 20.87% +2.79%
- Complexity 453 485 +32
============================================
Files 43 44 +1
Lines 3982 4125 +143
============================================
+ Hits 720 861 +141
- Misses 3262 3264 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
$levels
needs to be either [CONTEXT_MODULE]
or removed (since base_mod
already defines it that way). Otherwise, the posts will not be found by student searches.
Hey could you leave detailed instructions on how to test the search function? |
@rtschu ? |
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
============================================
- Coverage 21.51% 20.87% -0.65%
- Complexity 455 485 +30
============================================
Files 43 44 +1
Lines 4001 4125 +124
============================================
Hits 861 861
- Misses 3140 3264 +124
Continue to review full report at Codecov.
|
a46a6ff
to
58b3251
Compare
Hey Robin, |
absolutely, I meant to change the title to WIP until travis is ok have added that now :) |
b05c438
to
adbc74e
Compare
Global search works good only with full words, but not with word fragments (nice to have). Thanks for your work. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
============================================
+ Coverage 21.51% 24.59% +3.07%
- Complexity 455 486 +31
============================================
Files 43 44 +1
Lines 4001 4086 +85
============================================
+ Hits 861 1005 +144
+ Misses 3140 3081 -59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
closes #23 Provides basic search function via integration into the global search api