Skip to content

Build with Debug configuration for iPhone simulator #116

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devxoul
Copy link

@devxoul devxoul commented Mar 2, 2020

Summary

This patch makes it available to use some debug features such as RxSwift's TRACE_RESOURCES. For now, we don't have a way to set compiler flags for debug build.

  post_install do |installer|
    installer.pods_project.targets.each do |target|
      target.build_configurations.each do |config|
-       if target.name == 'RxSwift'
+       if target.name == 'RxSwift' and config.name == 'Debug'
          config.build_settings['OTHER_SWIFT_FLAGS'] ||= ['-D', 'TRACE_RESOURCES']
        end
      end
    end
  end

Note

I'm not sure if there was a background that Release configuration is necessary for iPhone simulator.

@muukii
Copy link

muukii commented Dec 6, 2020

@devxoul

Hi, I think this feature would be helpful for development.
I'm working on the maintaining branch. It's better to get this PR.

What do you think?

#137

@muukii
Copy link

muukii commented Dec 6, 2020

Plus, just in case, it might be good to add a flag to enable this feature in order to ship safely.

@innocarpe
Copy link

innocarpe commented Jan 4, 2021

@muukii, Would you merge this pr to your maintaining repo? Then we can move on our cocoapods-binary repo to yours 🙏

@muukii
Copy link

muukii commented Jan 4, 2021

Yes, I can merge it.
But should not add an option to enable this feature?
Anyway my thing should be okay adding after.

@innocarpe
Copy link

innocarpe commented Jan 4, 2021

@muukii I guess it'll be okay because there is the condition config.name == 'Debug'. I think this actually works as a kind of flag.

We've used forked repo since Mar. 2020 and there is no specific issues!

@innocarpe
Copy link

@muukii I'll be appreciated if you apply this changes in your repo ☺️

@muukii
Copy link

muukii commented Jan 10, 2021

@innocarpe
Hi, I'm sorry I don't have time to do this now.
Would you create a PR for my repo?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants