Skip to content

WIP: fetch problem tags from GraphQL & sort problems by natural order #51

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AerysNan
Copy link

@AerysNan AerysNan commented Sep 11, 2020

Here is the corresponding issue.

Updates

  1. Fetch problem tags through GraphQL API instead of hardcoding them.
  2. Use natural-orderBy to sort the problems by their frontend ID.

Problems

Currently vscode-leetcode relies on leetcode-cli's console output, which may restrict the scalability. Though leetcode-cli can fetch tags and store them in the cache, vscode-leetcode still cannot get them unless we output tag information to the console. But that would make the console message overwhelming.

  • So should we let vscode-leetcode visit leetcode-cli's cache file?

@AerysNan
Copy link
Author

Might need some suggestions. @yihong0618 @jdneo

@yihong0618
Copy link

@AerysNan can we avoid using natural-orderBy package just write a function? And I think jdneo is a little busy, we can wait for him to review.

@AerysNan
Copy link
Author

@AerysNan can we avoid using natural-orderBy package just write a function? And I think jdneo is a little busy, we can wait for him to review.

Sure, I'll consider it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants