RingBuffer: Introduce consume_raw_n() #1173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-e-s-o
approved these changes
May 21, 2025
Comment on lines
+994
to
+997
| // Consume exactly one item | ||
| let ret = mgr.consume_raw_n(1); | ||
| assert!(ret == 1); |
There was a problem hiding this comment.
Should we also add a test making sure that with two events (or more) events available we also consume & report two? 1 really could mean so many things, so I'd think there is some value add.
There was a problem hiding this comment.
That's a good idea, I'll add a test for this case as well, thanks.
|
Updated the |
libbpf provides the ring_buffer__consume_n() API to consume up to a certain amount of items from ringbuffers [1]. Add the new method consume_raw_n() also in RingBuffer to provide the same functionality. This is needed by sched_ext to allow user-space schedulers (based on scx_rustland_core) to selectively consume task items from BPF ring buffer [2]. [1] https://lore.kernel.org/bpf/20240406092005.92399-1-andrea.righi@canonical.com/ [2] https://github.com/sched-ext/scx/blob/ea361886f714b968092a1ea14bdee8330beb4d5f/rust/scx_rustland_core/assets/bpf.rs#L228 Signed-off-by: Andrea Righi <arighi@nvidia.com>
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libbpf provides the ring_buffer__consume_n() API to consume up to a certain amount of items from ringbuffers [1].
Add the new method consume_raw_n() also in RingBuffer to provide the same functionality.
This is needed by sched_ext to allow user-space schedulers (based on scx_rustland_core) to selectively consume task items from BPF ring buffer [2].
[1] https://lore.kernel.org/bpf/20240406092005.92399-1-andrea.righi@canonical.com/
[2] https://github.com/sched-ext/scx/blob/ea361886f714b968092a1ea14bdee8330beb4d5f/rust/scx_rustland_core/assets/bpf.rs#L228