Add new plugin bumpit #672
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca-ruz
force-pushed
the
bumpchannelopen
branch
3 times, most recently
from
c572a67 to
1a9e95e
Compare
|
@ca-ruz looks great so far! I think the testing around the emergency reserve could be improved.. there is an edge case where the user creates a channel and then their change output becomes the emergency reserve, and if they bump this output with too high a fee, the emergency reserve could end up getting inadvertently spent. Please either add a very loud warning about this in the README and in the RPC help strings, or add some logic that removes this footgun. |
|
@chrisguida Hey! Thanks for the feedback. I added logic that prevents the user from spending the emergency reserve and added a couple of other features. I also updated the tests, all should be passing now. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Core Lightning plugin to bump an open channel transaction by creating a CPFP, useful when the funding transaction is stuck in the mempool or has a low fee.
https://github.com/ca-ruz/bumpit
Note: This plugin does not work with lightning version 24.08 because it uses the
listaddressesrpc call, which was introduced in version 24.11.