staticaddr: channel funding with deposits #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
force-pushed
the
static-open-channel
branch
2 times, most recently
from
60286d0 to
97049c1
Compare
hieblmi
force-pushed
the
static-open-channel
branch
6 times, most recently
from
6c330e5 to
4184f2d
Compare
hieblmi
changed the title
hieblmi
force-pushed
the
static-open-channel
branch
4 times, most recently
from
fbe14d2 to
59975f0
Compare
|
Rebased |
hieblmi
force-pushed
the
static-open-channel
branch
from
59975f0 to
596b1df
Compare
|
Rebased |
hieblmi
force-pushed
the
static-open-channel
branch
from
596b1df to
4d0e787
Compare
|
Rebased master |
� Conflicts: � staticaddr/utils.go
hieblmi
force-pushed
the
static-open-channel
branch
from
4d0e787 to
818b915
Compare
|
Rebased master. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
openchannelsubcommand to static addresses.It provides the same experience as
lncli openchannel.Exmples:
Open a channel with all available deposits:
Open a channel with specified local funding amount, coin-selected from available deposits under fee and dust considerations.
Open a channel from two deposits AAA and BBB while taking their combined value(fundmax) as funding amount and considering fees and dust limit.
Open a channel from two deposits AAA and BBB while taking a specified amount(local_amt) as funding amount and considering fees and dust limit.
TODOs: