staticaddr: minor fixes #956
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
force-pushed
the
minor-static-fixes
branch
from
5b287c8 to
9f7726a
Compare
sputn1ck
reviewed
Jun 16, 2025
staticaddr/deposit/manager.go
Outdated
| } | ||
| wg.Wait() |
There was a problem hiding this comment.
I don't think this commit makes sense. If we recover into the action waitforexpirysweptaction this recover will block until the tx is confirmed, making loop unusable for uncertain block times.
There was a problem hiding this comment.
A solution would be to make the action non-blocking (e.g. by moving receiving from the notifiers into a goroutine and sending an event to the fsm)
There was a problem hiding this comment.
Thank you for the catch @sputn1ck. I removed this commit.
hieblmi
force-pushed
the
minor-static-fixes
branch
from
9f7726a to
22266d6
Compare
sputn1ck
approved these changes
Jun 16, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #954, ignore first commit