staticaddr: monitor tx id of expiry sweep #996
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @hieblmi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the staticaddr component by improving the monitoring of expiry sweep transactions. Previously, the system might have relied solely on the script for confirmation tracking. With these changes, the transaction ID of an expiry sweep is now captured and stored when it's published. This stored ID is then used to specifically monitor the confirmations of that exact transaction, addressing a known issue and ensuring more robust and accurate tracking of sweep progress.
Highlights
- Storing Expiry Sweep Transaction ID: The transaction ID of a published expiry sweep is now explicitly stored within the deposit FSM's state (
f.deposit.ExpirySweepTxid) immediately after publication. - Improved Confirmation Monitoring for Expiry Sweeps: The
WaitForExpirySweepActionnow leverages the stored transaction ID when registering for confirmation notifications. This allows for more precise and reliable monitoring of the specific expiry sweep transaction that was initiated by the system.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, # here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request enhances the static address expiry sweep monitoring by storing and using the transaction ID. When publishing the sweep transaction, its ID is now saved. This ID is then used when waiting for confirmations, allowing for more efficient monitoring compared to just watching the script address. The implementation is correct and handles cases where the transaction ID is not known. I have one minor suggestion to improve a comment for better clarity and maintainability.
fixes #971