Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

logicalType/decimal: fix default values #291

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

rockwotj
Copy link
Collaborator

This fixes: #202

@rockwotj rockwotj force-pushed the master branch 2 times, most recently from 3b80db7 to 750e1de Compare December 18, 2024 14:59
@rockwotj rockwotj changed the title default values: fix logical types for default values logicalType/decimal: fix default values Dec 18, 2024
Copy link
Collaborator

@mihaitodor mihaitodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @rockwotj! :shipit:

Unlike timestamp types which accepts native values, decimal types must
be big.Rat, which means defaults need to be converted.

This fixes: linkedin#202
@rockwotj rockwotj merged commit e1419b3 into linkedin:master Jan 10, 2025
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't specify default values for LogicalType: "decimal" fields
2 participants