verbs: Query QP data in order on non x86 platforms #1606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkkranz
force-pushed
the
query_data_in_order_fix
branch
from
70679e1 to
b4b0368
Compare
|
I don't think this is right, it would break things like PPC. The platform check is supposed to be in the common code, and the driver check is only about how the device works on PCI. You should probably just add ARM to the inclusion list, though I imagine there are some wonky ARMs that don't work, they may not matter in practice. |
dkkranz
force-pushed
the
query_data_in_order_fix
branch
from
b4b0368 to
3e995d5
Compare
EFA can support 128 bytes blocks write in-order for some Grace platforms, so allow querying data in-order for ARM platforms in general. Reviewed-by: Michael Margolin <mrgolin@amazon.com> Reviewed-by: Yonatan Nachum <ynachum@amazon.com> Signed-off-by: Daniel Kranzdorf <dkkranzd@amazon.com>
dkkranz
force-pushed
the
query_data_in_order_fix
branch
from
3e995d5 to
fc236b7
Compare
|
Applied your suggestion, thanks |
|
@jgunthorpe Kind reminder |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EFA can support 128 bytes blocks write in-order for some Grace platforms. Move the check on x86 architecture to the mlx5 provider implementation.
Reviewed-by: Michael Margolin mrgolin@amazon.com
Reviewed-by: Yonatan Nachum ynachum@amazon.com