Skip to content

Add video pausing option on VideoView #469

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VatamanuBogdan
Copy link
Contributor

I added a video pausing option on VideoView to facilitate complex animation synchronization on the client side.

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2024

CLA assistant check
All committers have signed the CLA.

@hiroshihorie
Copy link
Member

Hi, thanks for your contribution. I think I put isEnabled for this purpose of pausing rendering. Doesn't it work well for you ?
Screenshot 2024-08-29 14 04 48

Instead of adding more properties, it would be great if you can optimize the logic of existing isEnabled property.

@VatamanuBogdan
Copy link
Contributor Author

Hi, thank you for the response. I tried to use isEnabled but when it's false the VideoView becomes transparent instead of pausing on the last frame.
If it's ok for you I can move the pausing logic I wrote to isEnabled to stop the VideoView on the last frame when it's false and to continue the rendering when it's true.

@adrian-niculescu
Copy link

Hi, thank you for the response. I tried to use isEnabled but when it's false the VideoView becomes transparent instead of pausing on the last frame. If it's ok for you I can move the pausing logic I wrote to isEnabled to stop the VideoView on the last frame when it's false and to continue the rendering when it's true.

Hi, @hiroshihorie, what do you think?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants