-
Notifications
You must be signed in to change notification settings - Fork 132
Recording permission check at SDK level #688
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to
refer to the manpage for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Starting a fresh app with
try! AudioManager.shared.setRecordingAlwaysPreparedMode(true)
looks like a deadlock (or the popup appears underneath) - What's the reason for this change?
@pblazej I think you need to test with the LKTestHost app, it might be blocking at the permissions dialog. However, I believe I can disable this check for the Simulator. The purpose of this check is that in some cases, the audio engine appears to start but only produces empty frames. I want to ensure the condition is valid, otherwise, an error should be thrown. |
Hm, I'm testing with |
@pblazej Ok, I think I can repro it. It happens when you call it from main thread before UI gets initialized maybe. |
Check perms right before engine input is requested to be enabled.
CLT-1548