feat: Create NetStandard 2.0 library #1510
Conversation
Split the library in two parts: One runtime library which targets .NET Standard 2.0 and one test library that targets .NET 6 and consumes the runtime library. This way, Xunit and other test-related libraries are not required to be deployed when referencing Look#. It is recommended to use the lowest/oldest .NET Standard version which under which your library can execute to maximize compatibility. In addition, add support for setting custom headers on a request-by-request basis. This is required because Looker requires the User-Agent header to be present when acquiring an embed session.
…egen into ksjoberg-netstandard-lib
|
@jkaster or @josephaxisa can either of you comment on this change? |
HttpMethod.Patch is no longer recognized Also improved reserved word support However, Rider and/or .NET Core test runners completely fail to run tests now so I can't verify this version although it builds successfully with only some warnings
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
# Conflicts: # spec/Looker.4.0.json # spec/Looker.4.0.oas.json
|
@ksjoberg Can you pull down this branch and see if you can get the tests to work? I don't currently have a windows machine available to me and my linux box with Rider is failing to run the tests. Thanks. |
|
I checked and there are 7 tests failing and 17 tests passing. You can run the tests from the command prompt using |
|
Thanks, @ksjoberg! I ran out of time to work on this more last week, but I'll be able to resume work on it again this week, and JetBrains has also suggested a work-around to get the tests running locally for me. If that works, progress will be much more rapid. |
feat: Create NetStandard 2.0 library #1398