-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement [BLB] Collation #13193
Open
tiera3
wants to merge
8
commits into
magefree:master
Choose a base branch
from
tiera3:blb-collation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+210
−1
Open
Implement [BLB] Collation #13193
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0872f09
Implement [BLB] Collation
tiera3 f946c69
remove unimplemented cards
tiera3 fc92bf6
Delete Mage.Sets/src/mage/Bloomburrow.java
tiera3 1a31e92
Add files via upload
tiera3 0b0d830
Add files via upload
tiera3 79c7b5b
Add files via upload
tiera3 54d999b
Add basic variants
tiera3 fd58707
reballanced uncommons due to ommited uncommon
tiera3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add files via upload
- Loading branch information
commit 1a31e922823e754a7ccd03ceaa1f8d9b87419d56
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not support adding this level of complex collation with all these unimplemented cards. It's great for complete sets, or if the unimplemented card/cards are actually out of scope (e.g. text changing), but not good if this code needs to be manually adjusted when another card is implemented. Easy problem is if cards get implemented without being added to booster generation, and hard problem is if there's a mistake in adding the card and it throws off booster generation.
What I would recommend if there are unimplemented cards:
In either case - we need a general play booster implementation (not using collators) to deal with mostly-implemented sets like this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enough data has been collected that the implementation is complete. (The small amount of uncertainty in the uncommonA run is irrelevant because there is never more than one card being drawn from uncommonA at a time.)
However, the fact that an uncommon card (Heirloom Epic) is unimplemented means that mathimatical adjustments were needed. I can understand your hesitation with this set.
For the rares and mythics, they simply need to be added to the approriate runs when implemented and no other changes. Also the reason I left the commented out complete run, so that when the other cards are implemented, it can simply be uncommented and the other version removed.
Generic booster generation is a little complicated for Play Booster sets because you have both the foil wildcard and non-foil wildcard to worry about. If anyone wants to go ahead and code it, for Bloomburrow, the data suggests: