-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[WHO] Implement Everybody Lives! #13369
base: master
Are you sure you want to change the base?
Conversation
Hmm I have no idea why the tests failed during the first build… and why it worked on the second. |
Cause on first run master contained a failed verify test: 17e0c82 |
Yes, but what I don't get is that after I pulled from remote my own master branch now gives me a different test error : [INFO] Standard out Wrong card 3320: Brightglass Gearhulk
Wrong card 3355: Earthrumbler
........................ [INFO] Standard out Compilation works with -DskipTests. |
Open |
Thanks ! That did it. |
Implement [[Everybody Lives!]].
Part of #10653.
I created several common files to implement this ; I am not sure if this is the preferred way.
In GainAbilityAllPlayersEffect, I copied some logic from GainAbilityControllerEffect, including use of custom duration, but I'm not sure if it is necessary - how is it different from Duration.WhileOnBattlefield ?
As always, thanks for your work.