-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[DFT] Guidelight Matrix and Kolodin, Triumph Caster #13411
Open
Jmlundeen
wants to merge
5
commits into
magefree:master
Choose a base branch
from
Jmlundeen:guidelight-matrix-kolodin
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add static method from SaddleAbility to saddle a permanent add common saddle effect refactor Alacrian Armory with new saddle effect
ssk97
reviewed
Mar 14, 2025
@Override | ||
public boolean apply(Game game, Ability source) { | ||
Permanent targetMount = game.getPermanent(getTargetPointer().getFirst(game, source)); | ||
if (targetMount == null || !targetMount.hasSubtype(SubType.MOUNT, game)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Target Mount" should be handled in target filter, so I don't think this is necessary
ssk97
reviewed
Mar 14, 2025
this.addAbility(new EntersBattlefieldTriggeredAbility(new DrawCardSourceControllerEffect(1))); | ||
// {2}, {T}: Target Mount you control becomes saddled until end of turn. Activate only as a sorcery. | ||
Ability saddledAbility = new ActivateAsSorceryActivatedAbility(new SaddleTargetMountEffect(), | ||
new CompositeCost(new ManaCostsImpl<>("{2}"), new TapSourceCost(), "{2}, {T}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add costs instead of creating a single CompositeCost
changed SaddleTargetMountEffect apply to pass first target changed GuidelightMatrix to not use composite cost
Cards updated, thanks |
ssk97
reviewed
Mar 16, 2025
…light-matrix-kolodin # Conflicts: # Mage.Sets/src/mage/sets/Aetherdrift.java
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #13033
This PR adds both Guidelight Matrix and Kolodin, Triumph Caster. Also, because both of these cards cause mounts to become saddled, the PR also includes changes to create a common effect to saddle a target and adding a static ability to Saddle class. Additionally, Alacrian Armory is refactored to use the new method.