Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix errors when calling df.agg("nunique") #2970

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Fix errors when calling df.agg("nunique") #2970

wants to merge 5 commits into from

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Apr 26, 2022 •
edited
Loading

What do these changes do?

Fix incorrect redirection of groupby.nunique into transform by applying map-combine-agg paradigm.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added type: bug Something isn't working mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Apr 26, 2022
@wjsi wjsi added this to the v0.9.0rc3 milestone Apr 26, 2022
@wjsi wjsi force-pushed the bugfix/groupby_nunique branch 5 times, most recently from 20c97da to 4d1e7b4 Compare April 27, 2022 06:49
@wjsi wjsi changed the title [WIP] Fix support for groupby-nunique Use map-combine-agg to execute groupby.nunique Apr 27, 2022
@wjsi wjsi marked this pull request as ready for review April 27, 2022 06:52
@wjsi wjsi requested review from qinxuye and hekaisheng as code owners April 27, 2022 06:52
@wjsi wjsi force-pushed the bugfix/groupby_nunique branch from bbf6e18 to 5069080 Compare April 28, 2022 07:36
@wjsi wjsi force-pushed the bugfix/groupby_nunique branch from 5069080 to 6f52547 Compare May 5, 2022 12:44
@wjsi wjsi marked this pull request as draft May 5, 2022 16:53
@wjsi wjsi force-pushed the bugfix/groupby_nunique branch 5 times, most recently from 7a1b55d to 2e2aa9d Compare May 7, 2022 03:46
@wjsi wjsi force-pushed the bugfix/groupby_nunique branch from 2e2aa9d to 63c45fb Compare May 7, 2022 06:07
@wjsi wjsi changed the title Use map-combine-agg to execute groupby.nunique Fix errors when calling df.agg("nunique") May 7, 2022
@wjsi wjsi force-pushed the bugfix/groupby_nunique branch from 63c45fb to 5c67580 Compare May 7, 2022 10:24
@qinxuye qinxuye removed this from the v0.9.0rc3 milestone May 7, 2022
@qinxuye qinxuye added this to the v0.10.0a1 milestone May 7, 2022
@qinxuye qinxuye removed this from the v0.10.0a1 milestone Jun 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@qinxuye qinxuye Awaiting requested review from qinxuye

@hekaisheng hekaisheng Awaiting requested review from hekaisheng

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
mod: dataframe to be backported Indicate that the PR need to be backported to stable branch type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjsi @qinxuye