Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a universal function to replace subgraph in OptimizationRule #3353

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ericpai
Copy link
Contributor

@ericpai ericpai commented Jun 27, 2023

This PR adds a univeral function replace_subgraph to OptimizationRule for later use. The unit test cases are added as well.

Fixes #3352

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@ericpai ericpai force-pushed the refine/subgraph branch 2 times, most recently from b9e6430 to 12525c0 Compare June 27, 2023 09:33
@ericpai ericpai marked this pull request as ready for review June 27, 2023 09:41
@ericpai ericpai requested a review from a team as a code owner June 27, 2023 09:41
wjsi
wjsi previously approved these changes Jun 28, 2023
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems errors are not relevant.

@ericpai ericpai force-pushed the refine/subgraph branch from e060abf to 8505806 Compare July 3, 2023 05:15
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A more universal function to replace subgraph in OptimizationRule
3 participants