Skip to content

feat(slider): updated slider to adhere material design specification #5730

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

zZHorizonZz
Copy link
Contributor

@zZHorizonZz zZHorizonZz commented Oct 10, 2024

This pull request updates the slider component to the newest version of the Material Design specification.

image

There are a couple of things that need to be tested, discussed, and improved:

  • I changed the tokens in the internal folder, but from what I understand, these tokens are generated internally?
  • Speaking of tokens I think there is space to add new tokens for example for gap between track and handle.
  • Since the theme changer uses sliders, it needs to be redesigned a bit as currently it looks weird.
  • I'm not able to test the disabled attribute as catalog compilation throws an error. This error is not related to any of my changes, as I tested it and it's broken even if you try adding the slider components without my modification. (I think it's something about SSR.)
  • Also I'm not able to test this in browsers like safari, etc.

Closes #5466

@zZHorizonZz zZHorizonZz changed the title Feat/slider design v2 feat(slider): updated slider to adhere material design specification Oct 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sliders to new NTC guidelines
1 participant