Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Android & PC some fixes #21

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

elifian
Copy link
Contributor

@elifian elifian commented Jan 3, 2025

  1. Fixed the colors of the avatars.
image
  1. Background of the player.
image
  1. The color of the emoji status has been changed to white.
image

image
  1. Fixed the send video button (it was completely white).
image

@elifian
Copy link
Contributor Author

elifian commented Jan 3, 2025

This is for users who will be passing by :)
https://t.me/addtheme/dark_shell_2

@maximilionus maximilionus linked an issue Jan 3, 2025 that may be closed by this pull request
@maximilionus maximilionus self-requested a review January 3, 2025 16:12
@maximilionus
Copy link
Owner

You did a great job, thank you for fixing this stuff. I don't really have much time for this project lately, so it's been in idle state for a while.

Give me a few moments to check the changes.

@elifian
Copy link
Contributor Author

elifian commented Jan 3, 2025

I've made some more minor changes to the theme on the PC, on android. You can see it here https://t.me/addtheme/dark_shell_2

Including the white search bar in emoji and in the attach audio menu (android)

@elifian
Copy link
Contributor Author

elifian commented Jan 3, 2025

I would also like to thank you for such a perfect theme. Even though it hasn't received updates for a long time. <3

@elifian elifian changed the title Android some fixes Android & PC some fixes Jan 4, 2025
@maximilionus
Copy link
Owner

  1. Fixed the send video button (it was completely white).
image

Is it possible to make the button's background white and turn the icon itself black, or this will require more complex tweaks?

@elifian
Copy link
Contributor Author

elifian commented Jan 4, 2025

Is it possible to make the button's background white and turn the icon itself black, or this will require more complex tweaks?

Unfortunately, no, I tried. Apparently, the button in the center is static and you can't change its color, so this is the only way to do it...

@maximilionus
Copy link
Owner

Unfortunately, no, I tried. Apparently, the button in the center is static and you can't change its color, so this is the only way to do it...

Oh, okay, that's to be expected.

I see that you also made some changes to the desktop theme. Please add the changes you made to the PR description so I can check them.

And you can also just make new commits without force-pushing - I'm not putting any limits on the commits amount.

@elifian
Copy link
Contributor Author

elifian commented Jan 4, 2025

If something is not clear, ask away, my English is not very good 😅.

And you can also just make new commits without force-pushing - I'm not putting any limits on the commits amount.

I'm just not a fan of creating excessive commits, sorry.

I see that you also made some changes to the desktop theme. Please add the changes you made to the PR description so I can check them.

PC:

  1. Changed the background color of "Saved Messages" (The same thing is done for the android)
  2. The title color has been changed so that it does not stand out from the main color in the theme.


3. Fixed the colors of the names

Android (Additional changes):

  1. Changed the background color of "Saved Messages"


2. The background of the sticker search has been changed



3. The background of the audio search has been changed



The search bars have the same hex color

@elifian
Copy link
Contributor Author

elifian commented Jan 4, 2025

I almost forgot, the color of the "verified account" and "status" has also been changed from blue to white.
image
image
Both on PC and Android.

@maximilionus
Copy link
Owner

So you just went and singlehandedly fixed all the long-standing issues of this theme on multiple platforms. You are a true hero my friend, none the less 👍

Copy link
Owner

@maximilionus maximilionus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The desktop fixes are really nice, you did a great job. Already applied the changes to the cloud variant.

The Android variant will take some more time to test out, as it's a bit more tricky to merge correctly.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing, finally the custom colors are here. New title and search bars look very consistent now.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to export the theme binary here, I can do it myself later.

@maximilionus
Copy link
Owner

If something is not clear, ask away, my English is not very good 😅.

Я отлично понимаю русский. Не стоит утруждаться с переводчиком, можешь дальше на нем писать.

@maximilionus maximilionus added desktop Theme for Windows and Linux clients android Theme for Android client labels Jan 5, 2025
@maximilionus maximilionus changed the base branch from master to development January 9, 2025 16:51
@maximilionus maximilionus merged commit 16215f1 into maximilionus:development Jan 9, 2025
@maximilionus
Copy link
Owner

maximilionus commented Jan 9, 2025

That's it. HUGE thank you for such a massive contribution, basically keeping this project alive.

Changes are already applied to the cloud versions of both Android and Desktop themes, repository release will be out in a few days.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
android Theme for Android client desktop Theme for Windows and Linux clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macos - Tested; White emoji search bar on Android Multiple styling issues
2 participants