Skip to content

Proofreading - The Marketplace section #9516

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 10 commits into from
Jun 13, 2025

Conversation

NicoletaComan
Copy link
Collaborator

No description provided.

@NicoletaComan NicoletaComan self-assigned this May 12, 2025
@NicoletaComan NicoletaComan marked this pull request as ready for review June 5, 2025 14:25
Copy link
Collaborator

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NicoletaComan
Sorry it has taken so long to review this. I have started - see my comments so far. I'll try to continue tomorrow or next week.
Looks like some good changes and you have found things which have slipped through our change processes which is great.
If you want to change anything before I continue, based on my comments, let me know. Otherwise I'll continue as quickly as I can.

Copy link
Collaborator

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nicoleta,
This is a huge PR. My ask in the original list was to review the Marketplace home page rather than the whole of the Marketplace.
There are lots of good things here - I have added a few comments below. Most of these are picking up things which were already in the doc and are probably more for a second pass rather than necessarily needing to be addressed in this proofreading round.
In general the changes are good and I don't think it is necessary, or a good use of my time, to review the whole PR. Please can you take another look at what you have done and come back to me if you feel that you need to discuss anything which has changed in priority or in some other way.

This is a huge piece of work - well done. However, in future, I would suggest that this number of changes is split into several smaller PRs. This makes it easier to review and less likely to end up with conflicts.

Let me know if you have any questions.

@NicoletaComan
Copy link
Collaborator Author

Thank you for the review!
I have applied the requested changes, and I will merge this PR.

@NicoletaComan NicoletaComan merged commit 3cc5ff9 into development Jun 13, 2025
2 checks passed
@NicoletaComan NicoletaComan deleted the markteplace-module-proofreading branch August 21, 2025 08:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants