-
Notifications
You must be signed in to change notification settings - Fork 183
WIP: fix pre-commit-clang-format not working on Windows #390
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: develop
Are you sure you want to change the base?
Conversation
This is a WIP PR made to track the work done for this issue. Please don't merge this yet |
I will resume work after 4 march, since I have my college exams till then |
Please set the PR as draft when it is WIP. |
@Coder-Manan any updates on this one? |
I am currently learning about both the scripts, will work after that. |
It would be interesting to have it in a single script: https://codegolf.stackexchange.com/a/66700 |
I have started porting the script to powershell, piece by piece. I will be highly obliged if you review it and tell me any corrections which may be needed |
While porting the script I found that we may need to port |
I have created a new subfolder for implementing this on windows only. Now it is cross-platform, but it lacks windows implementation, it won't give errors with windows anymore: 69fad4b @Coder-Manan If you are still interested you can continue implementing it in this folder: https://github.com/metacall/core/tree/develop/githooks/win32 Feel free to implement everything in the same PR. |
Description
The pre commit hook which checks for clang version installed doesn't work on Windows OS as expected. This PR aims at fixing that.
Fixes #370
Type of change
Checklist:
make test
orctest -VV -R <test-name>
)../docker-compose.sh test &> output
and attached the output.OPTION_BUILD_SANITIZER
or./docker-compose.sh test-sanitizer &> output
andOPTION_TEST_MEMORYCHECK
.OPTION_BUILD_THREAD_SANITIZER
or./docker-compose.sh test-thread-sanitizer &> output
.Helgrind
in case my code works with threading.make clang-format
in order to format my code and my code follows the style guidelines.If you are unclear about any of the above checks, have a look at our documentation here.