Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow relationships to be compared to scalars #182

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow relationships to be compared to scalars #182

wants to merge 2 commits into from

Conversation

multimeric
Copy link
Contributor

@multimeric multimeric commented Nov 21, 2019 •
edited
Loading

This is based on the recommendations part of the spec, which lets you do things like: GET /comments?filter[post]=1, even though filter[post] isn't actually an integer.

In addition, I've allowed queries like filter[id]=1,2,3, which internally is converted into a has operator.

I added tests for these changes.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 90.801% when pulling e3e1fed on TMiguelT:relationship-filter into b44bc08 on miLibris:master.

@coveralls
Copy link

coveralls commented Nov 21, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 90.845% when pulling 8ec2aad on TMiguelT:relationship-filter into b44bc08 on miLibris:master.

@multimeric multimeric mentioned this pull request Nov 21, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@multimeric @coveralls