Skip to content

/micropython/bluetooth/aioble/examples/temp_client.py: Fix units in ADV_INTERVAL constant. #927

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavesCodeMusings
Copy link

@DavesCodeMusings DavesCodeMusings commented Oct 4, 2024

The aioble README already has this fix: 57ce3ba

This makes a similar correction to the temp_sensor.py example.

Similar to fix already applied to README micropython@57ce3ba
@DavesCodeMusings DavesCodeMusings changed the title Fix units in ADV_INTERVAL constant Fix units in ADV_INTERVAL constant. Oct 4, 2024
@DavesCodeMusings DavesCodeMusings changed the title Fix units in ADV_INTERVAL constant. /micropython/bluetooth/aioble/examples/temp_client.py: Fix units in ADV_INTERVAL constant. Oct 4, 2024
@dpgeorge
Copy link
Member

Thanks for the contribution. Line 53 will also need fixing, as per the CI error.

Also, probably worth fixing the examples/l2cap_file_server.py example as well?

@DavesCodeMusings
Copy link
Author

@dpgeorge Unfortunately, I found out about the guidelines for commits after I submitted a pull request. So yeah, there are some things I need to straighten out. Getting there... slowly. Still trying to figure out how I can do all this from the github.com web interface. Not so sure about the git -s signing bit. Can that be done in a browser or command-line only?

@dpgeorge
Copy link
Member

Not so sure about the git -s signing bit. Can that be done in a browser or command-line only?

It should work through the browser now, I just enabled the relevant setting. If you add a new commit it should be signed.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants