Skip to content

drivers/sensor/mcp9808: Add MCP9808 temperature sensor driver. #958

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MarcoMiano
Copy link

@MarcoMiano MarcoMiano commented Jan 1, 2025

Add single-file module for the Microchip MCP9808 precision temperature sensor. The module provides a class for reading the emperature and for configuring the sensor. It has type/value checking for some of the critical parts of the configuration as well as a debug mode for easier testing during development.

It includes a test file designed to run directly on a board with a sensor connected to test both the module and the sensor.

Both module and tests file are thoroughly documented in the code directly. For more information read README.md on https://github.com/MarcoMiano/mip-mcp9808

edit:
It is my first pr here so bear with me with all this pre-commit stuff... (had black fighting with ruff in vscode for a moment)
I still don't get what the check doesn't like in my commits... I don't want to use my email to sign-off stuff.

Add single-file module for the Microchip MCP9808 precision temperature
sensor. The module provides a class for reading the temperature and for
configuring the sensor. It has type/value checking for some of the
critical parts of the configuration as well as a debug mode for easier
testing during development.

It includes a test file designe to run directly on a board with a sensor
connected to test both the module and the sensor.

Both module and tests file are thoroughly documented in the code
directly. For more information read README.md on MarcoMiano/mip-mcp9808

Signed-off-by: MarcoMiano <58668074+MarcoMiano@users.noreply.github.com>
@MarcoMiano MarcoMiano reopened this Jan 1, 2025
Signed-off-by: MarcoMiano <58668074+MarcoMiano@users.noreply.github.com>
@MarcoMiano MarcoMiano marked this pull request as ready for review January 1, 2025 20:24
Signed-off-by: MarcoMiano <58668074+MarcoMiano@users.noreply.github.com>
ruff suggest to use .isinstance() to check class type but bool doen't
have .isinstance() method.

ruff suggest to use only float in some places but i don't like it
the code should be more flexible.

Signed-off-by: MarcoMiano <58668074+MarcoMiano@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant