fix: removes unused parameters

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
microsoft · Feb 4, 2025 · 9cd7aae · 9cd7aae
1 parent f3a601b
commit 9cd7aae
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/src/Microsoft.OpenApi.Readers/OpenApiYamlReader.cs b/src/Microsoft.OpenApi.Readers/OpenApiYamlReader.cs
@@ -77,9 +77,9 @@ public ReadResult Read(MemoryStream input,
         }
 
         /// <inheritdoc/>
-        public static ReadResult Read(JsonNode jsonNode, OpenApiReaderSettings settings, string format = null)
+        public static ReadResult Read(JsonNode jsonNode, OpenApiReaderSettings settings)
         {
-            return _jsonReader.Read(jsonNode, settings, OpenApiConstants.Yaml);
+            return _jsonReader.Read(jsonNode, settings);
         }
 
         /// <inheritdoc/>

diff --git a/src/Microsoft.OpenApi/Reader/OpenApiJsonReader.cs b/src/Microsoft.OpenApi/Reader/OpenApiJsonReader.cs
@@ -60,11 +60,9 @@ public ReadResult Read(MemoryStream input,
         /// </summary>
         /// <param name="jsonNode">The JsonNode input.</param>
         /// <param name="settings">The Reader settings to be used during parsing.</param>
-        /// <param name="format">The OpenAPI format.</param>
         /// <returns></returns>
         public ReadResult Read(JsonNode jsonNode,
-                               OpenApiReaderSettings settings,
-                               string format = null)
+                               OpenApiReaderSettings settings)
         {
             if (jsonNode is null) throw new ArgumentNullException(nameof(jsonNode));
             if (settings is null) throw new ArgumentNullException(nameof(settings));

diff --git a/test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt b/test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt
@@ -1463,7 +1463,7 @@ namespace Microsoft.OpenApi.Reader
     {
         public OpenApiJsonReader() { }
         public Microsoft.OpenApi.Reader.ReadResult Read(System.IO.MemoryStream input, Microsoft.OpenApi.Reader.OpenApiReaderSettings settings) { }
-        public Microsoft.OpenApi.Reader.ReadResult Read(System.Text.Json.Nodes.JsonNode jsonNode, Microsoft.OpenApi.Reader.OpenApiReaderSettings settings, string format = null) { }
+        public Microsoft.OpenApi.Reader.ReadResult Read(System.Text.Json.Nodes.JsonNode jsonNode, Microsoft.OpenApi.Reader.OpenApiReaderSettings settings) { }
         public System.Threading.Tasks.Task<Microsoft.OpenApi.Reader.ReadResult> ReadAsync(System.IO.Stream input, Microsoft.OpenApi.Reader.OpenApiReaderSettings settings, System.Threading.CancellationToken cancellationToken = default) { }
         public T ReadFragment<T>(System.IO.MemoryStream input, Microsoft.OpenApi.OpenApiSpecVersion version, Microsoft.OpenApi.Models.OpenApiDocument openApiDocument, out Microsoft.OpenApi.Reader.OpenApiDiagnostic diagnostic, Microsoft.OpenApi.Reader.OpenApiReaderSettings settings = null)
             where T : Microsoft.OpenApi.Interfaces.IOpenApiElement { }