fix/headers reference #2091
Merged
fix/headers reference #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (OpenApiConstants.Links.Equals(propertyName, StringComparison.Ordinal) && | ||
| responseElement?.Links != null && | ||
| responseElement.Links.TryGetValue(mapKey, out var linkElement) && | ||
| linkElement is IOpenApiReferenceable referenceable2) |
Check warning
Code scanning / CodeQL
Useless type test Warning
There was a problem hiding this comment.
This will be fixed when we migrate the link proxy design pattern implementation to
| @@ -63,7 +64,7 @@ | |||
| public OpenApiResponse(OpenApiResponse response) | |||
| { | |||
| Description = response?.Description ?? Description; | |||
| Headers = response?.Headers != null ? new Dictionary<string, OpenApiHeader>(response.Headers) : null; | |||
| Headers = response?.Headers != null ? new Dictionary<string, IOpenApiHeader>(response.Headers) : null; | |||
Check warning
Code scanning / CodeQL
Virtual call in constructor or destructor Warning
There was a problem hiding this comment.
This will be fixed when we fix the proxy design pattern for that type.
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
…references Signed-off-by: Vincent Biret <vibiret@microsoft.com>
|
baywet
requested review from
irvinesunday,
darrelmiller,
gavinbarron,
millicentachieng,
MaggieKimani1 and
andrueastman
as code owners
andrueastman
approved these changes
Jan 28, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial #1998, review #2090 first