-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix/immutable reference #2121
fix/immutable reference #2121
Conversation
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Quality Gate failedFailed conditions |
@captainsafia this is where I wanted to get:
The only drawback I can see is having to call RegisterComponents and/or SetReferenceHostDocument on the OpenAPIDocument based on what the consumer is doing. But we could "hide that" by calling those methods before serialization. We'll try to release soon, in fact #2115 is already up so you can test that ASAP. I've noticed a much better developer experience and reliability on my end in kiota, openapi.net.odata, plugins, and API manifest libs. (linking locally) |
makes document for references optional. Cleans up internal constructors for references, makes references immutable to avoid side effects
related #1998