Adding sample instructions property #259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zateutsch, would love your review here to ensure consistency |
azchohfi
requested changes
Mar 20, 2025
| @@ -94,6 +94,7 @@ internal static partial class ScenarioCategoryHelpers | |||
| ScenarioType = ScenarioType.{{scenarioCategory.Key}}{{scenario.Key}}, | |||
| Name = "{{scenario.Value.Name}}", | |||
| Description = "{{scenario.Value.Description}}", | |||
| Instructions = "{{scenario.Value.Instructions}}", | |||
There was a problem hiding this comment.
The way this is setup, you would create an empty string, not a null string, but the type is defined as nullable in the Scenario class (in the SG project). Lets just make sure typing there is meaningful. It seems like this property shouldn't be null, so if it is we should fail, not write "". If, on the other hand, the type should be nullable (like how it is defined), the type in the main project should not be initialized as "", but rather with null.
zateutsch
approved these changes
Mar 20, 2025
Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com>
Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com>
Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com>
Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the sample instructions to a dedicated property. Closes: #258
For now, showing this under an i button: