Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding Ollama support #289

Merged
merged 11 commits into from
Mar 21, 2025
Merged

Adding Ollama support #289

merged 11 commits into from
Mar 21, 2025

Conversation

nmetulev
Copy link
Member

No description provided.

@nmetulev nmetulev marked this pull request as ready for review March 19, 2025 06:45
@nmetulev nmetulev requested a review from azchohfi March 19, 2025 06:45
Copy link
Contributor

@zateutsch zateutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the only thing I wonder about is where to indicate that this is available in the app, but I think that can be added later on

@nmetulev nmetulev enabled auto-merge March 21, 2025 05:06

var lines = new List<string>();

Task.WhenAny(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is all of this needed? If the process has closed already, can't you just read the output?

@nmetulev nmetulev merged commit 65e9ff2 into main Mar 21, 2025
3 checks passed
@nmetulev nmetulev deleted the nmetulev/ollama branch March 21, 2025 05:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants