Use the new MSVC preprocessor #1734
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps the we should enabling the new code based on _MSVC_TRADITIONAL? |
|
Is this really necessary? this appears to only effect internal test headers, not public API headers, So I don't think this should fix any bugs related to using cpprest and the new preprocessor at the same time. |
barcharcraz
approved these changes
Dec 7, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC has a new preprocessor (https://devblogs.microsoft.com/cppblog/announcing-full-support-for-a-c-c-conformant-preprocessor-in-msvc/). To compile code with MSVC and C++20 we need to use the new preprocessor (
/Zc:preprocessor).This change updates cpprestsdk to use
/Zc:preprocessoron versions of MSVC that support it (>= 16.6, which is _MSC_VER 1926).Without code changes,
/Zc:preprocessorcauses build breaks due to empty__VA_ARGS__in the macros defined in CheckMacros.h and TestMacros.h. Those headers already have versions of the macros that use the conformant##__VA_ARGS__syntax for non-MSVC compilers, so this change uses those existing macros for MSVC as well, on versions of MSVC that support/Zc:preprocessor.