-
Notifications
You must be signed in to change notification settings - Fork 125
FEAT: Support 5.2- Added JSONARRAY Feature Support #460
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Django 5.2 and Python 3.13 while introducing a new SQL Server–specific implementation for the JSONArray function.
- Updates tox.ini, setup.py, and Azure Pipelines configuration to include Django 5.2 and Python 3.13 testing.
- Implements a new SQL Server function (sqlserver_json_array) to handle JSONArray operations with support for nested JSON structures and multiple data types.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
tox.ini | Added Django 5.2 testing environments and updated dependency declarations. |
setup.py | Updated classifiers and Django dependency range to support Django 5.2. |
mssql/functions.py | Introduced SQL Server JSONArray implementation and registered it for Django 5.2. |
azure-pipelines.yml | Updated build matrix to run tests against Django 5.2 with various Python versions. |
Comments suppressed due to low confidence (1)
mssql/functions.py:235
- [nitpick] Consider passing numeric values in their native type instead of converting them to strings, unless the intended SQL parameter type requires string conversion.
params.append(str(val))
tox.ini
Outdated
{py310, py311, py312,py313}-django51 | ||
{py310, py311, py312,py313}-django52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider adding spaces after commas in the environment list (e.g., changing '{py310, py311, py312,py313}-django52' to '{py310, py311, py312, py313}-django52') to match the formatting of other entries.
{py310, py311, py312,py313}-django51 | |
{py310, py311, py312,py313}-django52 | |
{py310, py311, py312, py313}-django51 | |
{py310, py311, py312, py313}-django52 |
Copilot uses AI. Check for mistakes.
azure-pipelines.yml
Outdated
@@ -24,6 +24,19 @@ jobs: | |||
|
|||
strategy: | |||
matrix: | |||
Python3.13 - Django 5.2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you create a separate PR for setup.py
,azure-pipelines.yml
and tox.ini
changes? asking since it would be better to track
The PR can be called - "Support 5.2 - Test & Pipeline Changes
52bb9fd
to
ad12745
Compare
This pull request introduces support for Django 5.2 and Python 3.13, alongside adding a new SQL Server-specific implementation for the
JSONArray
function. Key changes span updates to CI configurations, dependency declarations, and the implementation of the new database function.Support for Django 5.2 and Python 3.13:
azure-pipelines.yml
: Added new matrix configurations for Django 5.2 with Python versions 3.10 through 3.13 to ensure compatibility testing. [1] [2]setup.py
: Updated classifiers to include Django 5.2 and Python 3.13, and extended the Django dependency range to<5.3
. [1] [2]tox.ini
: Added Django 5.2 to theenvlist
and defined its dependency range. [1] [2]New SQL Server
JSONArray
Implementation:mssql/functions.py
: Introduced thesqlserver_json_array
function to handle theJSONArray
operation for SQL Server, including support for nested JSON structures and various data types. Registered this implementation for Django 5.2 and above. [1] [2]