FEAT: Support 5.2- Added composite primary key #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for composite primary keys for the MSSQL backend in Django 5.2 and later. It conditionally imports CompositePrimaryKey, updates database features to reflect composite primary key support, and revises schema creation logic to generate a proper PRIMARY KEY clause for composite keys.
- Introduces conditional imports for CompositePrimaryKey based on the Django version.
- Updates DatabaseFeatures to include composite primary key support and disable tuple lookups when applicable.
- Enhances schema creation logic to handle composite primary keys by generating and inserting a PRIMARY KEY SQL clause.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| mssql/schema.py | Added logic to generate a composite primary key SQL clause during table creation. |
| mssql/features.py | Conditionally sets support flags for composite primary keys and tuple lookups. |
| # CompositePrimaryKey support is only available in Django 5.2 and later | ||
| supports_composite_primary_keys = django_version >= (5, 2) | ||
| if django_version >= (5, 2) and isinstance(CompositePrimaryKey, type): | ||
| # Set fallback tupple lookup support |
There was a problem hiding this comment.
Misspelling: 'tupple' should be corrected to 'tuple'.
Suggested change
| # Set fallback tupple lookup support | |
| # Set fallback tuple lookup support |
Copilot uses AI. Check for mistakes.
NandanaRaol
changed the title
NandanaRaol
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for composite primary keys in Django 5.2 and later for the MSSQL backend. It includes changes to conditionally import
CompositePrimaryKey, modifyDatabaseFeatures, and update schema creation logic to handle composite primary keys.Support for Composite Primary Keys:
mssql/features.py: Added conditional import ofCompositePrimaryKeybased on Django version and updatedDatabaseFeaturesto includesupports_composite_primary_keys. Also setsupports_tuple_lookupstoFalseas a fallback when composite primary keys are supported. [1] [2]mssql/schema.py: Added conditional import ofCompositePrimaryKeyand updated thecreate_modelmethod to detect and handle composite primary keys. This includes generating aPRIMARY KEYSQL clause for composite keys and inserting it into the constraints list during table creation. [1] [2] [3]