Add a Program.Main() override with a throwOnError parameter #3140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensuring that playwright is properly installed can be done by running the following code:
This is fine when the installation succeeds and the exit code is 0. But when running under xUnit.net (which does not capture the console output) and the installation fails with exit code 1, then it becomes impossibly hard to diagnose the root cause of the failure.
For example, a failure can be triggered by deleting the installed browers in the
ms-playwright
cache directory and setting thehttps_proxy
environment variable to an invalid proxy:http://127.0.0.1:33333
.Under these conditions, running with the new
throwOnError
parameter becomes diagnosable.This throws a
PlaywrightException
with the exact command executed and its output, making it clear what the problem is.Fixes #3139